Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(backend): fix type error(s) in security fixes #15009

Merged
merged 6 commits into from
Nov 21, 2024

Conversation

kakkokari-gtyih
Copy link
Contributor

@kakkokari-gtyih kakkokari-gtyih commented Nov 21, 2024

What

Why

Additional info (optional)

CIが通るまで待つ

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

(cherry picked from commit fa3cf6c2996741e642955c5e2fca8ad785e83205)
(cherry picked from commit 1758f29364eca3cbd13dbb5c84909c93712b3b3b)
(cherry picked from commit 23c4aa25714af145098baa7edd74c1d217e51c1a)
(cherry picked from commit 36af07abe28bec670aaebf9f5af5694bb582c29a)
@github-actions github-actions bot added packages/backend Server side specific issue/PR packages/backend:test labels Nov 21, 2024
Copy link
Contributor

github-actions bot commented Nov 21, 2024

このPRによるapi.jsonの差分
差分はありません。
Get diff files from Workflow Page

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 43.75000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 39.86%. Comparing base (53e827b) to head (99884c2).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
packages/backend/src/core/HttpRequestService.ts 16.66% 5 Missing ⚠️
...end/src/core/activitypub/models/ApPersonService.ts 66.66% 3 Missing ⚠️
...kages/backend/src/core/RemoteUserResolveService.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #15009       +/-   ##
============================================
+ Coverage    19.33%   39.86%   +20.53%     
============================================
  Files          728     1563      +835     
  Lines       103798   197735    +93937     
  Branches       991     3634     +2643     
============================================
+ Hits         20066    78836    +58770     
- Misses       83178   118324    +35146     
- Partials       554      575       +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

K4rakara and others added 2 commits November 21, 2024 11:31
(cherry picked from commit 6027b516e1c82324d55d6e54d0e17cbd816feb42)
@syuilo syuilo merged commit 3a6c2aa into misskey-dev:develop Nov 21, 2024
31 of 32 checks passed
@syuilo
Copy link
Member

syuilo commented Nov 21, 2024

🙏

@kakkokari-gtyih kakkokari-gtyih deleted the fix-sec-1 branch November 21, 2024 03:10
HotoRas pushed a commit to HotoRas/misskey-neko that referenced this pull request Nov 24, 2024
* Fix type error in security fixes

(cherry picked from commit fa3cf6c2996741e642955c5e2fca8ad785e83205)

* Fix error in test function calls

(cherry picked from commit 1758f29364eca3cbd13dbb5c84909c93712b3b3b)

* Fix style error

(cherry picked from commit 23c4aa25714af145098baa7edd74c1d217e51c1a)

* Fix another style error

(cherry picked from commit 36af07abe28bec670aaebf9f5af5694bb582c29a)

* Fix `.punyHost` misuse

(cherry picked from commit 6027b516e1c82324d55d6e54d0e17cbd816feb42)

* attempt to fix test: make yaml valid

---------

Co-authored-by: Julia Johannesen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend:test packages/backend Server side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants